Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initializeIcons function call to load from new CDN location (Fixes #1249) #1250

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

jack-vinitsky
Copy link
Contributor

Default CDN being loaded by the initializeIcons method was decommissioned on January 15, 2025. See microsoft/fluentui#33612

Motivation and Context

Fixes #1249 - Empty Icons

Description

Updates call to initializeIcons() in index.tsx to reference a specific CDN location.

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

Default CDN being loaded was decommissioned on January 15, 2025.
@FerronN
Copy link

FerronN commented Jan 31, 2025

@sarah-widder Could you approve this?

@jack-vinitsky
Copy link
Contributor Author

I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="BeiGene, USA, Inc."

Copy link
Contributor

@sarah-widder sarah-widder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@sarah-widder sarah-widder merged commit f288e4e into microsoft:main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty icons
4 participants